Writing this down here because it took me a while to figure out for myself…
ONAP OOM deploys ONAP using Kubernetes, which effectively means Docker images at the moment. It needs to fetch a lot of Docker images, so there is a convenient script provided to pre-pull those images to make install faster and more reliable.
The script in the OOM codebase isn’t very flexible, so Jira issue OOM-655 was filed for a better script. The script was covered in code review 30169. Disappointingly, the code reviewer there doesn’t seem to have actually read the jira issue or the code before abandoning the patch — which isn’t very impressive.
So how do you get the nicer pre-pull script?
Its actually not too hard once you know the review ID. Just do this inside your OOM git clone:
$ git review -d 30169
You might be prompted for your gerrit details because the ONAP gerrit requires login. Once git review has run, you’ll be left sitting in a branch from when the review was uploaded that includes the script:
$ git branch master * review/james_forsyth/30169
Now just rebase that to bring it in mine with master and get on with your life:
$ git rebase -i origin Successfully rebased and updated refs/heads/review/james_forsyth/30169.
You’re welcome. I’d like to see the ONAP community take code reviews a bit more seriously, but ONAP seems super corporate (even compared to OpenStack), so I’m not surprised that they haven’t done a very good job here.